Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(router): simplify Submission type #10691

Closed

Conversation

MichaelDeBoey
Copy link
Member

Follow-up of #10413

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

⚠️ No Changeset found

Latest commit: a34cb12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11
Copy link
Contributor

I'm ok with this duplication for now. I can see a future where we narrow the enctypes appropriately across the Submission union since it can only be encType: "application/json" when json is present, etc. I also think that formMethod can only technically be MutationFormMethod for json/text submissions since they can't be converted to URLSearchParams like FormData can. So if we ever tackle those we'd have to undo this DRY change.

@MichaelDeBoey MichaelDeBoey deleted the simplify-Submission-type branch July 12, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants