Fix issues with useFormAction/useResolvedPath for dot paths in param/splat routes #10983

brophdawg11 · 2023-10-31T18:54:28Z

Second shot at a fix for #10922

Originally fixed in #10933 and reverted in #10965 due to issues.

The main issue seems to boil down to useResolvedPath's longstanding behavior of using pathnameBase to construct the current route hierarchy. pathnameBase never contains the splat - but pathname does.

This breaks a few existing uni tests that rely on the existing behavior - need to review with @mjackson.

…splat routes

changeset-bot · 2023-10-31T18:54:32Z

🦋 Changeset detected

Latest commit: 22a3657

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
react-router	Patch
react-router-dom	Patch
react-router-dom-v5-compat	Patch
react-router-native	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

brophdawg11 · 2023-10-31T19:03:38Z

Looking at some of the existing tests, I can see the dropped splat maybe being expected for a use case such as:

// Assume current url is /parent/something
<Route path="parent">
  <Route path="static" element={<h1>Static</h1>} />
  <Route path="*" element={<Link to="./static">Click</Link>} />
</Route>

Where you want the link to go to /parent/static and not /parent/something/static - but that's somewhat different from the current behavior in non-splat routes:

// Assume current url is /parent/something
<Route path="parent">
  <Route path="static" element={<h1>Static</h1>} />
  <Route path=":param" element={<Link to="./static">Click</Link>} />
</Route>

When using a dynamic param that link will resolve to /parent/something/static

brophdawg11 · 2023-11-02T19:22:03Z

@mjackson and I traced this back to #8086 and determined its just been a long-standing bug for splat route handling. The example there shows a .. going up to /files which implies that a . on a splat route should contain the splat portion.

brophdawg11 · 2023-11-02T19:30:53Z

packages/react-router-dom/__tests__/data-browser-router-test.tsx

@@ -2895,7 +2973,7 @@ function testDomRouter(
          let { container } = render(<RouterProvider router={router} />);

          expect(container.querySelector("form")?.getAttribute("action")).toBe(
-            "/foo?a=1"
+            "/foo/bar?a=1"


This existing test was asserting the buggy behavior. When no action is specified it should inherit the current path including the splat portion

brophdawg11 · 2023-11-02T19:31:06Z

packages/react-router-dom/__tests__/data-browser-router-test.tsx

@@ -2915,7 +2993,7 @@ function testDomRouter(
          let { container } = render(<RouterProvider router={router} />);

          expect(container.querySelector("form")?.getAttribute("action")).toBe(
-            "/foo"
+            "/foo/bar"


This existing test was asserting the buggy behavior. When action="." is specified it should inherit the current path including the splat portion

brophdawg11 · 2023-11-02T19:31:26Z

packages/react-router-dom/__tests__/link-href-test.tsx

@@ -530,7 +530,7 @@ describe("<Link> href", () => {
      });

      expect(renderer.root.findByType("a").props.href).toEqual(
-        "/inbox/messages"
+        "/inbox/messages/abc"


Same as above - this asserted the buggy behavior

brophdawg11 · 2023-11-02T19:41:31Z

packages/react-router-dom/__tests__/data-browser-router-test.tsx

+          expect(container.querySelector("form")?.getAttribute("action")).toBe(
+            "/foo"
+          );
+        });


New tests we didn't have before to ensure that the useResolvedPath changes don't make us accidentally pick up child route portions

mjackson

Looks good to me!

github-actions · 2023-11-14T14:27:20Z

🤖 Hello there,

We just published version 6.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions · 2023-11-16T14:42:38Z

🤖 Hello there,

We just published version 6.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

…splat routes (remix-run#10983)

This reverts commit f320378.

…n param/splat routes (#10983)" This reverts commit fe066bd.

* Revert "Fix other code paths for resolveTo from a splat route (#11045)" This reverts commit 58d421f. * Revert "Add additional test case for #10983" This reverts commit f320378. * Revert "Fix issues with useFormAction/useResolvedPath for dot paths in param/splat routes (#10983)" This reverts commit fe066bd. * Fix test * Add changeset

Fix issues with useFormAction/useResolvedPath for dot paths in param/…

b696de3

…splat routes

remix-cla-bot bot added the CLA Signed label Oct 31, 2023

brophdawg11 linked an issue Oct 31, 2023 that may be closed by this pull request

[Bug]: useResolvedPath breaks <Form> when used in a splat route #10922

Closed

Update tests

3ada561

brophdawg11 added 2 commits November 2, 2023 15:25

Updates

85b30e3

Remove redundant test

1618835

brophdawg11 commented Nov 2, 2023

View reviewed changes

brophdawg11 added 3 commits November 2, 2023 15:39

Updates

6deb430

Update changeset

78d5566

Single changeset

60b47e2

brophdawg11 commented Nov 2, 2023

View reviewed changes

Add note on bug fix

22a3657

mjackson approved these changes Nov 2, 2023

View reviewed changes

brophdawg11 merged commit fe066bd into dev Nov 3, 2023
3 checks passed

brophdawg11 deleted the brophdawg11/fix-form-action branch November 3, 2023 14:41

brophdawg11 mentioned this pull request Nov 3, 2023

[Bug]: useResolvedPath breaks <Form> when used in a splat route #10922

Closed

github-actions bot mentioned this pull request Nov 14, 2023

chore: Update version for release (pre) #11026

Merged

brophdawg11 mentioned this pull request Nov 14, 2023

Stabilize useBlocker remix-run/remix#7882

Merged

github-actions bot mentioned this pull request Nov 16, 2023

chore: Update version for release #11035

Merged

brophdawg11 added a commit that referenced this pull request Nov 20, 2023

Add additional test case for #10983

f320378

This was referenced Nov 20, 2023

Posting to nested forms without leading / modifies route (since v2.3.0) remix-run/remix#8054

Closed

[Bug]: Relative path's on splat routes are broken #11038

Closed

Fix other code paths for resolveTo from a splat route #11045

Merged

github-actions bot mentioned this pull request Nov 21, 2023

chore: Update version for release (pre) #11047

Merged

sgoll mentioned this pull request Nov 21, 2023

[Bug]: Regression of useResolvedPath in 6.19.0 #11048

Closed

github-actions bot mentioned this pull request Nov 22, 2023

chore: Update version for release #11050

Merged

birdofpreyru mentioned this pull request Nov 27, 2023

[Bug]: useResolvedPath breaking. #11052

Closed

RobinClowers mentioned this pull request Nov 28, 2023

[Bug]: Route relative links not working as expected #11067

Closed

jonathanpruvost pushed a commit to concordnow/react-router that referenced this pull request Nov 28, 2023

Fix issues with useFormAction/useResolvedPath for dot paths in param/…

5e671fe

…splat routes (remix-run#10983)

jonathanpruvost pushed a commit to concordnow/react-router that referenced this pull request Nov 28, 2023

Add additional test case for remix-run#10983

5bb5ceb

brophdawg11 mentioned this pull request Dec 1, 2023

[Bug]: useHref after the 6.19 update returns a different path than in 6.18 #11070

Closed

brophdawg11 added a commit that referenced this pull request Dec 1, 2023

Revert "Add additional test case for #10983"

c6c3ff2

This reverts commit f320378.

brophdawg11 added a commit that referenced this pull request Dec 1, 2023

Revert "Fix issues with useFormAction/useResolvedPath for dot paths i…

f3e2ac5

…n param/splat routes (#10983)" This reverts commit fe066bd.

brophdawg11 mentioned this pull request Dec 1, 2023

Revert useResolvedPath fix in splat routes #11078

Merged

brophdawg11 mentioned this pull request Dec 4, 2023

Add future.v7_relativeSplatPath flag #11087

Merged

1 task

github-actions bot mentioned this pull request Dec 5, 2023

chore: Update version for release (pre) #11089

Merged

github-actions bot mentioned this pull request Dec 13, 2023

chore: Update version for release #11114

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issues with useFormAction/useResolvedPath for dot paths in param/splat routes #10983

Fix issues with useFormAction/useResolvedPath for dot paths in param/splat routes #10983

brophdawg11 commented Oct 31, 2023

changeset-bot bot commented Oct 31, 2023 •

edited

Loading

brophdawg11 commented Oct 31, 2023

brophdawg11 commented Nov 2, 2023

brophdawg11 Nov 2, 2023

brophdawg11 Nov 2, 2023

brophdawg11 Nov 2, 2023

brophdawg11 Nov 2, 2023

mjackson left a comment

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 16, 2023

Fix issues with useFormAction/useResolvedPath for dot paths in param/splat routes #10983

Fix issues with useFormAction/useResolvedPath for dot paths in param/splat routes #10983

Conversation

brophdawg11 commented Oct 31, 2023

changeset-bot bot commented Oct 31, 2023 • edited Loading

🦋 Changeset detected

brophdawg11 commented Oct 31, 2023

brophdawg11 commented Nov 2, 2023

brophdawg11 Nov 2, 2023

Choose a reason for hiding this comment

brophdawg11 Nov 2, 2023

Choose a reason for hiding this comment

brophdawg11 Nov 2, 2023

Choose a reason for hiding this comment

brophdawg11 Nov 2, 2023

Choose a reason for hiding this comment

mjackson left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 16, 2023

changeset-bot bot commented Oct 31, 2023 •

edited

Loading