Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with changing fetcher key in a mounted component #11009

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fix bug with changing fetcher key in a mounted component #11009

merged 2 commits into from
Nov 13, 2023

Conversation

brophdawg11
Copy link
Contributor

Closes #11008

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 3639f21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Nov 9, 2023 that may be closed by this pull request
Fetcher with key not resetting when key changes #11008
Closed
1 task
@brophdawg11 brophdawg11 force-pushed the brophdawg11/changing-fetcher-key branch from 96c13c6 to 2acc01b Compare November 9, 2023 15:36
tatchi
tatchi reviewed Nov 13, 2023
View reviewed changes
packages/react-router-dom/index.tsx Outdated
Comment on lines 1554 to 1558
React.useEffect(() => {
if (key && key !== "" && key != fetcherKey) {
setFetcherKey(key);
}
}, [key, fetcherKey]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we set the state directly in render?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test that out - I always worry about that based on the "rules of hooks" and what not - but a re-reading of the docs makes it sound like this is a valid use case: https://react.dev/reference/react/useState#storing-information-from-previous-renders

@brophdawg11 brophdawg11 merged commit 811e9aa into dev Nov 13, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/changing-fetcher-key branch November 13, 2023 23:10
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

jonathanpruvost pushed a commit to concordnow/react-router that referenced this pull request Nov 28, 2023
@brophdawg11 @jonathanpruvost
Fix bug with changing fetcher key in a mounted component (remix-run#1…
7eccd8a 
…1009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatchi tatchi tatchi left review comments

@jacob-ebey jacob-ebey jacob-ebey approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetcher with key not resetting when key changes
3 participants
@brophdawg11 @tatchi @jacob-ebey