-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[added] Make router run work client side when given history class instance #1490
[added] Make router run work client side when given history class instance #1490
Conversation
+1 |
That would be very helpful, indeed |
There is some refactoring that could be done in ComponentWillMount to remove some of the repetition. Didn't want to make super drastic changes without some word on whether this is something that would be merged. |
Purposely removed UMD files as they had many compilation difference unrelated to this commit. |
There is one hiccup. Need to pass down routes on initialState and set it up in ComponentDidMount. Will pick it up tomorrow morning. |
Alright, fixed. Easy-peasy lemon squeeze-y. |
No sure about #1402, if you are having that issue can you give this pr a whirl? |
the api on master allows for this, we'll have guides around usage soon, but here's the guide for server rendering, which hopefully is enough for right now for you to see how to use client side https://github.com/rackt/react-router/blob/670b5ea630668be5bfa4079586d3fdd9306ba75f/docs/ServerRendering.md |
@ryanflorence The same can be run client side? |
Check if Router run was given a history class instance.
Then setup history class instance.
Add history object to nextState on successful callback.
closes #1486