Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] Make router run work client side when given history class instance #1490

Closed
wants to merge 1 commit into from
Closed

[added] Make router run work client side when given history class instance #1490

wants to merge 1 commit into from

Conversation

BerkeleyTrue
Copy link

Check if Router run was given a history class instance.
Then setup history class instance.
Add history object to nextState on successful callback.

closes #1486

@faergeek
Copy link
Contributor

faergeek commented Jul 6, 2015

+1

@olegakbarov
Copy link

That would be very helpful, indeed

@BerkeleyTrue
Copy link
Author

There is some refactoring that could be done in ComponentWillMount to remove some of the repetition. Didn't want to make super drastic changes without some word on whether this is something that would be merged.

BerkeleyTrue pushed a commit to freeCodeCamp/freeCodeCamp that referenced this pull request Jul 7, 2015
@BerkeleyTrue
Copy link
Author

Purposely removed UMD files as they had many compilation difference unrelated to this commit.

@BerkeleyTrue
Copy link
Author

There is one hiccup. Need to pass down routes on initialState and set it up in ComponentDidMount. Will pick it up tomorrow morning.

@BerkeleyTrue
Copy link
Author

Alright, fixed. Easy-peasy lemon squeeze-y.

BerkeleyTrue pushed a commit to freeCodeCamp/freeCodeCamp that referenced this pull request Jul 12, 2015
BerkeleyTrue pushed a commit to freeCodeCamp/freeCodeCamp that referenced this pull request Jul 23, 2015
@aripalo
Copy link

aripalo commented Aug 21, 2015

Hmm so does this fix #1402 (that invalid checksum error with isomorphic react because of <noscript>) and #1486 ..? If so, would love see this one merged then as that checksum error really is a pain in the butt for isomoprhic apps.

@BerkeleyTrue
Copy link
Author

No sure about #1402, if you are having that issue can you give this pr a whirl?

@ryanflorence
Copy link
Member

the api on master allows for this, we'll have guides around usage soon, but here's the guide for server rendering, which hopefully is enough for right now for you to see how to use client side https://github.com/rackt/react-router/blob/670b5ea630668be5bfa4079586d3fdd9306ba75f/docs/ServerRendering.md

@BerkeleyTrue
Copy link
Author

@ryanflorence The same can be run client side?

@BerkeleyTrue BerkeleyTrue deleted the feature/client-side-router-run branch October 12, 2015 00:23
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.0.0-beta3: Router Run client side
5 participants