Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back API changes ahead of interim release #2674

Closed
wants to merge 1 commit into from
Closed

Roll back API changes ahead of interim release #2674

wants to merge 1 commit into from

Conversation

taion
Copy link
Contributor

@taion taion commented Dec 8, 2015

This reverts commit d2af254522cba7f36c9980852801e66a98fe3e70.

This reverts commit d2af254522cba7f36c9980852801e66a98fe3e70.
@taion taion changed the title Revert "Add back remaining changes from master" Roll back API changes ahead of interim release Dec 8, 2015
@timdorr
Copy link
Member

timdorr commented Dec 8, 2015

Can we just create a 1.1.x branch and let master be the latest and greatest bleeding-edge stuff? We treat 0.13.x as a support release branch, so we can use 1.1.x the same way and keep things consistent.

@taion
Copy link
Contributor Author

taion commented Dec 8, 2015

We could do that; the interim-release branch (minus the top 2 commits, or with them) would be a clean starting point.

However, we do need to do stuff like update the changelog and the docs even for a v1.1.x release. I feel like it'd be marginally less work just to re-apply the API change commit. Otherwise we'd need to cherry-pick those docs updates.

@taion taion added this to the v1.1 milestone Dec 8, 2015
@timdorr
Copy link
Member

timdorr commented Dec 8, 2015

Except you'll have to update this "undo patch" of sorts against any further changes in master, which may create more conflicts as it diverges. That seems to me like a lot more work. Merge conflicts vs. copy-pasting some markdown? I can do that by hand if need be.

Let me push up a 1.1.x and let me know what you think.

@taion
Copy link
Contributor Author

taion commented Dec 8, 2015

We pick our poison either way. interim-release~2 is a clean 1.1.x branch if you want - has just the commits we need.

@timdorr
Copy link
Member

timdorr commented Dec 8, 2015

Let's cherry pick in commits and copy-paste any docs changes. Less history noise from reverting commits and such. Plus, contributors gets the right authorship (gotta fill the profile dot graph! 😄)

@timdorr timdorr closed this Dec 8, 2015
@taion
Copy link
Contributor Author

taion commented Dec 8, 2015

Sure - I've already done that on the branch though - no need to do so again

@timdorr
Copy link
Member

timdorr commented Dec 8, 2015

I think we did it differently. I did an interactive rebase, so I got the real commits instead of the merge commits. Maybe different settings? Anyways, the end result is the same. It's all good 👌

@taion
Copy link
Contributor Author

taion commented Dec 8, 2015

That's fine then - as long as the file content matches. Real commits probably better. Good to have a double check.

@taion taion deleted the revert-api-changes branch December 15, 2015 20:17
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants