-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll back API changes ahead of interim release #2674
Conversation
This reverts commit d2af254522cba7f36c9980852801e66a98fe3e70.
Can we just create a |
We could do that; the However, we do need to do stuff like update the changelog and the docs even for a v1.1.x release. I feel like it'd be marginally less work just to re-apply the API change commit. Otherwise we'd need to cherry-pick those docs updates. |
Except you'll have to update this "undo patch" of sorts against any further changes in Let me push up a 1.1.x and let me know what you think. |
We pick our poison either way. |
Let's cherry pick in commits and copy-paste any docs changes. Less history noise from reverting commits and such. Plus, contributors gets the right authorship (gotta fill the profile dot graph! 😄) |
Sure - I've already done that on the branch though - no need to do so again |
I think we did it differently. I did an interactive rebase, so I got the real commits instead of the merge commits. Maybe different settings? Anyways, the end result is the same. It's all good 👌 |
That's fine then - as long as the file content matches. Real commits probably better. Good to have a double check. |
This reverts commit d2af254522cba7f36c9980852801e66a98fe3e70.