-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support basename in static routers #9591
Conversation
🦋 Changeset detectedLatest commit: e471d01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -64,7 +64,6 @@ export function StaticRouter({ | |||
} | |||
|
|||
export interface StaticRouterProviderProps { | |||
basename?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To align with <RouterProvider>
we no longer accept a basename
as a prop, we inherit from the router passed to it. In the SSR case, that further inherits from the static handler.
Adds support for
basename
to static data routers. We accept it up front increateStaticHandler
, and then persist it throughcreateStaticRouter
/StaticRouterPRovider
Sample usage: