Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-router-dom): fix submitter serialization #9865

Merged
merged 7 commits into from
Jun 14, 2023
Merged

fix(react-router-dom): fix submitter serialization #9865

merged 7 commits into from
Jun 14, 2023
+249 −16

Commits on Jun 14, 2023

  1. fix(react-router-dom): fix submitter serialization 

    Now that evergreen browsers support the submitter parameter to
the FormData constructor, we can rely on that to correctly
populate the form data set (i.e. ensure they appear in the
right spot, ensure image buttons are encoded correctly).

For browsers that don't support it, we continue to just append
the submit button's entry to the end, and we also add rudimentary
support for image buttons. If developers want full support for
legacy browsers, they can use the formdata-submitter-polyfill,
just as this PR does for the jsdom tests.
    @jenseng
    jenseng committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    1a66cdf View commit details
    Browse the repository at this point in the history

  2. chore: fix comment

    @jenseng
    jenseng committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    317833b View commit details
    Browse the repository at this point in the history

  3. Bump jsdom, change polyfill appoach in tests

    @jenseng
    jenseng committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c9a473e View commit details
    Browse the repository at this point in the history

  4. inline buildFormData

    @brophdawg11 @jenseng
    brophdawg11 authored and jenseng committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    94ff578 View commit details
    Browse the repository at this point in the history

  5. remove @types/web now that we're on the latest TypeScript 

    this was previously needed to get the latest DOM types

also bump packages sizes
    @jenseng
    jenseng committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    ebf92b8 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev' into fix-form-submitters

    @brophdawg11
    brophdawg11 committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    7e2d339 View commit details
    Browse the repository at this point in the history

  7. Update changeset

    @brophdawg11
    brophdawg11 committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c297d9b View commit details
    Browse the repository at this point in the history