Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/vite): remove http2 pseudo headers from internal request #8049

Closed

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Nov 18, 2023

Closes: #7867

I'm thinking this PR could help as a short term workaround for @remix-run/web-fetch Headers validation error.
This might not be a mandatory since there is a simple user side workaround by setting server: { proxy: {} } in vite config.

Also as I wrote in #7867 (comment), the removal of @remix-run/web-fetch polyfill would also make this workaround obsolete, so if remix team has a plan to remove automatic polyfills for newer node versions (this could be related? #7823), then this change will not be necessary.

Please let me know if there's any concern with this approach.

Testing Strategy:

I verified the same patch fixes my reproduction hi-ogawa/remix-reproduction-7867#2

Copy link

changeset-bot bot commented Nov 18, 2023

🦋 Changeset detected

Latest commit: 1d3bb13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hi-ogawa hi-ogawa changed the title fix(remix-dev/vite): remove http2 pseudo headers from request fix(remix-dev/vite): remove http2 pseudo headers from internal request Nov 18, 2023
@hi-ogawa hi-ogawa marked this pull request as ready for review November 18, 2023 05:10
@pcattori
Copy link
Contributor

As stated here, superceded by #8062 and remix-run/web-std-io#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants