Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remotion: Improve video + audio playback performance #4883

Merged
merged 3 commits into from
Feb 13, 2025
Merged

remotion: Improve video + audio playback performance #4883

merged 3 commits into from
Feb 13, 2025

Conversation

JonnyBurger
Copy link
Member

@JonnyBurger JonnyBurger commented Feb 13, 2025 •
edited
Loading

Fixes 2 bugs, probably impacting a lot of apps using the Remotion Player.

  • When starting a video, we buffer until the first frame appears. This would allow other media playing alongside to do a seek even with a small deviation and make the problem worse. We now don't do this if the video seems to have readyState >= 3.
  • May never play audio or video if in buffering state

Feedback is welcome! https://www.remotion.dev/docs/player/playback-issues

@vercel Vercel
Copy link

vercel bot commented Feb 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 10:41am
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 10:41am

@JonnyBurger JonnyBurger merged commit 6d9b7a0 into main Feb 13, 2025
13 checks passed
@JonnyBurger JonnyBurger deleted the fix-runaway-audio-bug branch February 13, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonnyBurger