Skip to content
This repository has been archived by the owner on May 16, 2022. It is now read-only.

Images reprocessed and credits used without specifying --reprocess-existing flag #16

Closed
tim-gp opened this issue Jul 2, 2020 · 1 comment · Fixed by #17
Closed

Images reprocessed and credits used without specifying --reprocess-existing flag #16

tim-gp opened this issue Jul 2, 2020 · 1 comment · Fixed by #17

Comments

@tim-gp
Copy link

tim-gp commented Jul 2, 2020

Command used:

$ removebg --api-key <KEY> --extra-api-options crop=true --output-directory bg-removed/ files/*

Files already existed:

$ find .
./bg-removed
./bg-removed/014D6E0C-CCE2-460C-9E12-7E74BC697B7F.png
./files
./files/014D6E0C-CCE2-460C-9E12-7E74BC697B7F.jpeg

Yet the files seem to have been sent to the server again and the timestamps on the files in the bg-removed directory are fresh. I'm down about 40 credits too. :(
odlp added a commit that referenced this issue Jul 21, 2020
@odlp
Fix skipping existing images
e856fd3 
Unless reprocessing is allowed, existing images should be skipped
to preserve credits.

This functionality was broken when the auto-upgrade from PNG to ZIP
was introduced. It ended up checking if the .zip file already exists,
which it wouldn't because a .png is emitted when the .zip format is used.

Fixes #16

Source of bug:
e40648c
@odlp odlp mentioned this issue Jul 21, 2020
Merged
@groe groe closed this as completed in #17 Jul 21, 2020
@odlp
Copy link
Contributor

odlp commented Jul 21, 2020

Hi @TimGP,

Thanks for raising this issue and apologies for the inconvenience. I've released a fix in version 1.3.1.

Please do contact customer service if you haven't done so already to reinstate your credits.

Thanks,
Oli

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix skipping existing images remove-bg/go
2 participants
@tim-gp @odlp