This repository has been archived by the owner on May 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Update go version, reduce PNG file size, add goreleaser #22
Open
brewmanandi
wants to merge
29
commits into
master
Choose a base branch
from
ft-second-try-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- built "something" that made tests wreak havoc
- added release workflow
- added go-zlib for faster compression - it adds ~10 seconds processing time
otherguy
changed the title
Ft second try 2
Update go version, reduce PNG file size, add goreleaser
Jul 8, 2021
otherguy
suggested changes
Jul 8, 2021
SxDx
reviewed
Jul 13, 2021
We are looking for better solutions. |
I found this library that writes PNG with proper size: github.com/xyproto/imagelib (1.4 MB vs 14.6 MB) |
Attached the binary for mac OS |
SxDx
reviewed
Jul 26, 2021
- writing png directly for smaller file sizes
That download is not working for me. |
removebg.zip |
SxDx
suggested changes
Aug 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be closed right?
@brewmanandi this can be closed, right? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/kaleidoai/e43aedf9f2f146dd997f6c57a23543d5?v=039ae52a20594a11bc1ad83ff300f529&p=228d489333fa48f7ab8bf6eeaba8ac3d