Fix edit-time and infinte loop. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the break in the uid check. I also needed an empty dict return in the scan method to deal with no 'uid' found. |
yatharth
pushed a commit
to yatharth/Roam2Obsidian
that referenced
this pull request
Sep 25, 2021
Original description: Fix edit-time and infinte loop See PR for context: renerocksai#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks a lot for the script.
I found some error while converting mine database so I figure I would submit a PR.
The first one is the location of 'edit-time'. In some of my page, it's inside the
page['children'][0]dict, in some other page it is directly in thepagedict. I add a smallif elsearound that.The second one is infinite loop when reference not found. I haven't dig around the logic around that part yet but just add a break statement seems to work fine for me.
Hope this help.