feat(gradle): remove deepExtract (#14497)

Removes Gradle `deepExtract` option

BREAKING CHANGE: Option `deepExtract` is now removed and will be ignored

docs/usage/configuration-options.md

@@ -456,16 +456,6 @@ If you need to _override_ constraints that Renovate detects from the repository,
 !!! note
     Make sure not to mix this up with the term `compatibility`, which Renovate uses in the context of version releases, e.g. if a Docker image is `node:12.16.0-alpine` then the `-alpine` suffix represents `compatibility`.
 
-## deepExtract
-
-<!-- prettier-ignore -->
-!!! warning
-    The `deepExtract` configuration option is deprecated, and will be removed in a future Renovate release.
-
-If configured to `true`, then dependency extraction will be done using the relevant package manager instead of JavaScript-based parsing.
-
-This option applies only to the `gradle` manager.
-
 ## defaultRegistryUrls
 
 Override a datasource's default registries with this config option.

docs/usage/java.md

@@ -87,12 +87,6 @@ Any repository URLs found within will be added as `registryUrls` to extracted de
 
 ## Custom registry support, and authentication
 
-Unless using `deepExtract`, Renovate does not make use of authentication credentials available to Gradle.
-
-<!-- prettier-ignore -->
-!!! warning
-    The `deepExtract` configuration option is deprecated, and will be removed in a future Renovate release.
-
 The manager for Gradle makes use of the `maven` datasource.
 Renovate can be configured to access additional repositories and access repositories authenticated.
 

lib/config/migration.spec.ts

@@ -44,6 +44,7 @@ describe('config/migration', () => {
         onboarding: 'false' as never,
         multipleMajorPrs: true,
         gitFs: false,
+        deepExtract: true,
         ignoreNpmrcFile: true,
         separateMajorReleases: true,
         separatePatchReleases: true,

lib/config/migrations/migrations-service.ts

@@ -23,6 +23,7 @@ import type { Migration, MigrationConstructor } from './types';
 
 export class MigrationsService {
   static readonly removedProperties: ReadonlySet<string> = new Set([
+    'deepExtract',
     'gitFs',
     'groupBranchName',
     'groupCommitMessage',

lib/config/options/index.ts

@@ -208,15 +208,6 @@ const options: RenovateOptions[] = [
     cli: false,
     env: false,
   },
-  {
-    name: 'deepExtract',
-    description: `Enable extraction of dependencies using package managers.`,
-    type: 'boolean',
-    default: false,
-    cli: false,
-    env: false,
-    supportedManagers: ['gradle'],
-  },
   {
     name: 'repositoryCache',
     description: 'Option to do repository extract caching.',

lib/modules/manager/gradle-wrapper/artifacts-real.spec.ts

@@ -6,7 +6,7 @@ import { git, partial } from '../../../../test/util';
 import { GlobalConfig } from '../../../config/global';
 import type { RepoGlobalConfig } from '../../../config/types';
 import type { StatusResult } from '../../../util/git/types';
-import { ifSystemSupportsGradle } from '../gradle/deep/__testutil__/gradle';
+import { ifSystemSupportsGradle } from '../gradle/__testutil__/gradle';
 import type { UpdateArtifactsConfig } from '../types';
 import * as gradleWrapper from '.';
 

lib/modules/manager/gradle-wrapper/utils.ts

@@ -14,6 +14,7 @@ export const extraEnv = {
     '-Dorg.gradle.parallel=true -Dorg.gradle.configureondemand=true -Dorg.gradle.daemon=false -Dorg.gradle.caching=false',
 };
 
+// istanbul ignore next
 export function gradleWrapperFileName(): string {
   if (
     os.platform() === 'win32' &&

lib/modules/manager/gradle/shallow/__snapshots__/extract.spec.ts.snap → lib/modules/manager/gradle/__snapshots__/extract.spec.ts.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`modules/manager/gradle/shallow/extract extracts from cross-referenced files 1`] = `
+exports[`modules/manager/gradle/extract extracts from cross-referenced files 1`] = `
 Array [
   Object {
     "datasource": "maven",

lib/modules/manager/gradle/shallow/__snapshots__/parser.spec.ts.snap → lib/modules/manager/gradle/__snapshots__/parser.spec.ts.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`modules/manager/gradle/shallow/parser calculations parses fixture from "gradle" manager 1`] = `
+exports[`modules/manager/gradle/parser calculations parses fixture from "gradle" manager 1`] = `
 Array [
   Object {
     "currentValue": "1.5.2.RELEASE",

lib/modules/manager/gradle/deep/__testutil__/gradle.ts → lib/modules/manager/gradle/__testutil__/gradle.ts

@@ -39,7 +39,7 @@ function determineJavaVersion(): number {
     } catch (e) {
       error = e;
     }
-    if (javaVersionCommand.error) {
+    if (javaVersionCommand?.error) {
       error = javaVersionCommand.error;
     }
     if (error) {

lib/modules/manager/gradle/shallow/common.ts → lib/modules/manager/gradle/common.ts

@@ -1,4 +1,4 @@
-export { MAVEN_REPO } from '../../../datasource/maven/common';
+export { MAVEN_REPO } from '../../datasource/maven/common';
 
 export const JCENTER_REPO = 'https://jcenter.bintray.com/';
 export const GOOGLE_REPO = 'https://dl.google.com/android/maven2/';