Help with regex manager + autoReplaceStringTemplates

[setchy]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

None

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

It used to work, and then stopped

Wanted end result.

autoReplaceStringTemplate updates to "stick"

What you tried so far.

Not exactly sure if the below is related to https://github.com/renovatebot/renovate/issues/19844 - looks like a slightly different issue...

Recreation repository: https://github.com/setchy/renovate-bitbucket-pipelines

When debugging locally, the replacement does succeed, however during the below step when it confirms the update it fails to perform the new extract, which results in WARN: Error updating branch: update failure

renovate/lib/workers/repository/update/branch/auto-replace.ts

Lines 17 to 31 in ba64726

	const { manager, packageFile, depIndex } = upgrade;
	let newUpgrade: PackageDependency;
	try {
	const newExtract = await extractPackageFile(
	manager,
	newContent,
	packageFile!,
	upgrade
	);
	// istanbul ignore if
	if (!newExtract) {
	// TODO: fix types (#7154)
	logger.debug(`Could not extract ${packageFile!}`);
	return false;
	}

when bypassing this check locally, it produces the PR I am expecting - https://github.com/setchy/renovate-bitbucket-pipelines/pull/2/files

Relevant debug logs

Logs

Copy/paste the relevant log(s) here, between the starting and ending backticks

[setchy]

What am I overlooking in the regexManager rule which would allow the extractPackageFile to succeed on the newContent?

[setchy]

Re-reading docs: Using regexManager to update the dependency name in addition to version along with some trial and error, and finally got there

What I learnt

1. matchStringsStrategy must be combination
2. must have two matchStrings regex for both the current shape and the new shape
3. make sure to use {{{newVersion}}}, {{{newDigest}}} in the autoReplaceStringTemplate
4. Success

resulting regexManager config

"regexManagers": [
  {
    "description": "Bitbucket Pipelines: update to use authenticated image structure",
    "fileMatch": ["(^|\\/|\\.)bitbucket-pipelines.ya?ml$"],
    "matchStringsStrategy": "combination",
    "matchStrings": [
      "[ \\t]*image:\\s+(?<depName>[a-z-]+)(?::(?<currentValue>[a-z0-9.-]+))?(?:@(?<currentDigest>sha256:[a-f0-9]+))?",
      "[ \\t]*image:\\s+\\n\\s+name:\\s+(?<depName>[a-z-]+)(?::(?<currentValue>[a-z0-9.-]+))?(?:@(?<currentDigest>sha256:[a-f0-9]+))?\\s+username:\\s+\\$SOME_USER\\s+password:\\s+\\$SOME_PASSWORD\\s+email:\\s+\\$SOME_EMAIL"
    ],
    "datasourceTemplate": "docker",
    "autoReplaceStringTemplate": "image:\n  name: {{{packageName}}}{{#if newValue}}:{{{newValue}}}{{/if}}{{#if newDigest}}@{{{newDigest}}}{{/if}}\n  username: $SOME_USER\n  password: $SOME_PASSWORD\n  email: $SOME_EMAIL"
  }
]

[setchy]

Improved with the release of indentation capture groups

"regexManagers": [
    {
      "description": "Bitbucket Pipelines: update to use authenticated image structure",
      "fileMatch": [
        "(^|\\/|\\.)bitbucket-pipelines.ya?ml$"
      ],
      "matchStringsStrategy": "combination",
      "matchStrings": [
        "(?<indentation>[ \\t]*)image:\\s+(?<depName>[a-z-]+)(?::(?<currentValue>[a-z0-9.-]+))?(?:@(?<currentDigest>sha256:[a-f0-9]+))?",
        "(?<indentation>[ \\t]*)image:\\n\\s+name:\\s+(?<depName>[a-z-]+)(?::(?<currentValue>[a-z0-9.-]+))?(?:@(?<currentDigest>sha256:[a-f0-9]+))?\\n\\s+username: \\$SOME_USER\\n\\s+password: \\$SOME_PASSWORD\\n\\s+email: \\$SOME_EMAIL"
      ],
      "datasourceTemplate": "docker",
      "versioningTemplate": "docker",
      "autoReplaceStringTemplate": "{{{indentation}}}image:\n{{{indentation}}}  name: {{packageName}}{{#if newValue}}:{{{newValue}}}{{/if}}{{#if newDigest}}@{{{newDigest}}}{{/if}}\n{{{indentation}}}  username: $SOME_USER\n{{{indentation}}}  password: $SOME_PASSWORD\n{{{indentation}}}  email: $SOME_EMAIL"
    }
  ]