-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: trim permissions for codeql-analysis action #10839
Conversation
I'm not sure if we really need this, as this are all primary actions 🤔 |
What do you think @rarkins? |
It's still best practice, but hopefully never needed |
I'd say we're ready to merge and see what happens, I think this is OK, but you can never be sure until you actually run it... If the action breaks somehow after the merge, we can try out this suggestion from a collaborator:
|
🎉 This PR is included in version 25.56.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
codeql-analysis.yml
Context:
I think we can tighten down our permissions for the CodeQL action as well.
There's no official documentation in their README yet, but I did find this issue: github/codeql-action#464
Please read the linked issue before reviewing my PR, maybe I'm missing something important from that discussion!
In that issue a contributor to the project says:
I figured, we can try these permissions.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: