Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config)!: non-zero defaults for PR concurrent, hourly limits #19958

Merged
merged 14 commits into from
Jan 28, 2023
Merged

feat(config)!: non-zero defaults for PR concurrent, hourly limits #19958

merged 14 commits into from
Jan 28, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jan 21, 2023

Changes

Sets new defaults:

  • prConcurrentLimit: 10 (instead of 0)
  • prHourlyLimit: 2 (instead of 0)

Context

Closes #19800

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added the breaking Breaking change, requires major version bump label Jan 21, 2023
viceice
viceice reviewed Jan 21, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed tests

@rarkins rarkins changed the title feat!: default to rangeStrategy=auto, prefer update-lockfile feat!: non-zero defaults for PR concurrent, hourly limits Jan 21, 2023
@rarkins rarkins changed the title feat!: non-zero defaults for PR concurrent, hourly limits feat!(config): non-zero defaults for PR concurrent, hourly limits Jan 28, 2023
@rarkins rarkins changed the title feat!(config): non-zero defaults for PR concurrent, hourly limits feat(config)!: non-zero defaults for PR concurrent, hourly limits Jan 28, 2023
@rarkins rarkins changed the base branch from feat/19800-range-strategy-auto-default to v35 January 28, 2023 06:51
@rarkins rarkins merged commit e6b97d4 into v35 Jan 28, 2023
@rarkins rarkins deleted the feat/19781-default-limits branch January 28, 2023 07:52
rarkins added a commit that referenced this pull request Jan 29, 2023
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
4de8042 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
rarkins added a commit that referenced this pull request Jan 30, 2023
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
347d389 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
rarkins added a commit that referenced this pull request Jan 31, 2023
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
017e05f 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
rarkins added a commit that referenced this pull request Feb 4, 2023
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
25988d2 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
rarkins added a commit that referenced this pull request Feb 10, 2023
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
909357d 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
rarkins added a commit that referenced this pull request Feb 17, 2023
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
12c2286 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
rarkins added a commit that referenced this pull request Feb 20, 2023
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
8214646 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
rarkins added a commit that referenced this pull request Feb 23, 2023
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
b784f61 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
rarkins added a commit that referenced this pull request Feb 25, 2023
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
77d58b5 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
rarkins added a commit that referenced this pull request Feb 27, 2023
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
46ca5a4 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice left review comments

@HonkingGoose HonkingGoose HonkingGoose requested changes

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rarkins @viceice @HonkingGoose