Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config)!: add new option constraintsFiltering #19992

Merged
merged 13 commits into from
Jan 28, 2023
Merged

feat(config)!: add new option constraintsFiltering #19992

merged 13 commits into from
Jan 28, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Jan 23, 2023 •
edited by rarkins
Loading

Changes

Adds new option constraintsFiltering.

BREAKING CHANGE: PyPI releases will no longer be filtered by default based on constraints.python compatibility. To retain existing functionality, set constraintsFiltering=strict.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

BREAKING CHANGE: Python constraint version filtering will be disabled by default, needs to be opted into using constraintsFiltering=strict.

@RahulGautamSingh
Copy link
Collaborator Author

Default Mode:
Strict Mode:

@RahulGautamSingh RahulGautamSingh requested review from rarkins, HonkingGoose and viceice and removed request for rarkins and HonkingGoose January 23, 2023 17:43
@viceice viceice added the breaking Breaking change, requires major version bump label Jan 23, 2023
rarkins
rarkins requested changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just realized that constraintsFiltering would be shorter and better - can you rename?

@rarkins rarkins changed the title feat(config): add new option releaseConstraintFiltering feat(config): add new option constraintsFiltering Jan 24, 2023
rarkins
rarkins requested changes Jan 24, 2023
View reviewed changes
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/types.ts Outdated Show resolved Hide resolved
@rarkins rarkins changed the title feat(config): add new option constraintsFiltering feat(config)!: add new option constraintsFiltering Jan 24, 2023
@rarkins rarkins changed the base branch from main to v35 January 24, 2023 10:41
HonkingGoose
HonkingGoose suggested changes Jan 24, 2023
View reviewed changes
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
@rarkins rarkins merged commit ac35383 into renovatebot:v35 Jan 28, 2023
rarkins pushed a commit that referenced this pull request Jan 28, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
1f5ce38
rarkins pushed a commit that referenced this pull request Jan 29, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
3370c00
rarkins pushed a commit that referenced this pull request Jan 30, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
0977509
rarkins pushed a commit that referenced this pull request Jan 31, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
13846f0
rarkins pushed a commit that referenced this pull request Feb 4, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
f0e063e
rarkins pushed a commit that referenced this pull request Feb 10, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
f61a511
rarkins pushed a commit that referenced this pull request Feb 17, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
527f752
rarkins pushed a commit that referenced this pull request Feb 20, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
26acf2c
rarkins pushed a commit that referenced this pull request Feb 23, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
a42fe41
rarkins pushed a commit that referenced this pull request Feb 25, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
162e21d
rarkins pushed a commit that referenced this pull request Feb 27, 2023
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
3125af9
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose requested changes

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make release compatibility filtering opt-in
4 participants
@RahulGautamSingh @viceice @rarkins @HonkingGoose