Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go)!: default GOPROXY #20081

Merged
merged 2 commits into from
Jan 29, 2023
Merged

feat(go)!: default GOPROXY #20081

merged 2 commits into from
Jan 29, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jan 28, 2023

Changes

Set default GOPROXY value

Context

Closes #20040

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested review from zharinov and viceice January 28, 2023 08:08
viceice
viceice reviewed Jan 28, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title seems wrong

@rarkins rarkins changed the title feat(config)!: add new option constraintsFiltering (#19992) feat(go)!: default GOPROXY Jan 28, 2023
viceice
viceice approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do some more refactoring and cleanup later

@rarkins rarkins added the breaking Breaking change, requires major version bump label Jan 29, 2023
@rarkins rarkins merged commit 865316a into v35 Jan 29, 2023
@rarkins rarkins deleted the feat/20040-goproxy-default branch January 29, 2023 06:11
rarkins added a commit that referenced this pull request Jan 29, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
0994718 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this pull request Jan 30, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
4b8dca0 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this pull request Jan 31, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
352a9ae 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this pull request Feb 4, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
1fadf7b 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this pull request Feb 10, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
4ecd182 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this pull request Feb 17, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
0705159 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this pull request Feb 20, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
895cc26 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this pull request Feb 23, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
1b58035 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this pull request Feb 25, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
afa3062 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this pull request Feb 27, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
0282067 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@zharinov zharinov Awaiting requested review from zharinov

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rarkins @viceice