Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): default dockerImagePrefix to containerbase #20150

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Feb 1, 2023

Changes

Change dockerImagePrefix from renovate to containerbase.
Probably breaking so some users.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added the breaking Breaking change, requires major version bump label Feb 1, 2023
@viceice viceice requested a review from rarkins February 1, 2023 12:11
@viceice viceice changed the title feat(config): default dockerImagePrefix to containerbase feat(config)!: default dockerImagePrefix to containerbase Feb 1, 2023
@viceice viceice changed the title feat(config)!: default dockerImagePrefix to containerbase feat(config): default dockerImagePrefix to containerbase Feb 1, 2023
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
@viceice viceice requested a review from HonkingGoose February 1, 2023 14:52
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs.

@viceice viceice merged commit d93e64f into v35 Feb 1, 2023
@viceice viceice deleted the feat/containerbase-sidecar-image branch February 1, 2023 16:47
rarkins pushed a commit that referenced this pull request Feb 4, 2023
rarkins pushed a commit that referenced this pull request Feb 10, 2023
rarkins pushed a commit that referenced this pull request Feb 17, 2023
rarkins pushed a commit that referenced this pull request Feb 20, 2023
rarkins pushed a commit that referenced this pull request Feb 23, 2023
rarkins pushed a commit that referenced this pull request Feb 25, 2023
rarkins pushed a commit that referenced this pull request Feb 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants