Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config)!: forkProcessing #20759

Merged
merged 1 commit into from
Mar 5, 2023
Merged

feat(config)!: forkProcessing #20759

merged 1 commit into from
Mar 5, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 5, 2023

Changes

Alters config logic so that forked repos are included by default if autodiscover is false.

Context

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
@rarkins rarkins added the breaking Breaking change, requires major version bump label Mar 5, 2023
@rarkins rarkins requested review from viceice and secustor March 5, 2023 10:59
@rarkins rarkins linked an issue Mar 5, 2023 that may be closed by this pull request
@rarkins rarkins merged commit 9b2b69b into v35 Mar 5, 2023
@rarkins rarkins deleted the feat/20752-fork-auto branch March 5, 2023 16:23
rarkins added a commit that referenced this pull request Mar 8, 2023
Removes "includeForks" option and replaces with "forkProcessing". New default behavior is to process forks if automerge=false.

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
rarkins added a commit that referenced this pull request Mar 10, 2023
Removes "includeForks" option and replaces with "forkProcessing". New default behavior is to process forks if automerge=false.

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
rarkins added a commit that referenced this pull request Mar 10, 2023
Removes "includeForks" option and replaces with "forkProcessing". New default behavior is to process forks if automerge=false.

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
rarkins added a commit that referenced this pull request Mar 10, 2023
Removes "includeForks" option and replaces with "forkProcessing". New default behavior is to process forks if automerge=false.

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
rarkins added a commit that referenced this pull request Mar 10, 2023
Removes "includeForks" option and replaces with "forkProcessing". New default behavior is to process forks if automerge=false.

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
trajan0x added a commit to synapsecns/sanguine that referenced this pull request Mar 10, 2023
trajan0x added a commit to synapsecns/sanguine that referenced this pull request Mar 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic fork inclusion detection
3 participants