-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/copier): Implement manager #29215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need so many new config options? we don't have it for any other managers
I'd argue that Copier is somewhat different from other managers because it can impact each file in the repository in relatively dynamic ways. Also honestly, I tend to lean towards providing more configurability to users when it does not add significant complexity, but am not married to most of the options. I believe
|
We need to go back to the discussion for all of this. It's undesirable to bloat the configs with so many new options so we should discuss them one by one and reach agreement chest. |
I have removed all Copier-specific options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked by containerbase/base#2870
* correctly inquire for `allowScripts` * respect `ignoreScripts` * only log to debug
In case of simple renames, `git status` might detect it. It's not reported in the other fields, so we need to account for that.
🎉 This issue has been resolved in version 38.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Adds one self-hosted (copierTrust
) and one repository configuration (copierOptions
, with several children)Context
Closes #25556
[email protected]:some/repo
-style URLs (I don't think they are used widely though)Note: This is my first PR to a TypeScript project in general and I have limited prior experience with Renovate. I read the contribution guidelines and tried to follow existing examples, but
copier
is not a regular manager, so I hope this is how it should be done.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: