Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): don't break on npm workspace dir with a period #30483

Merged
merged 4 commits into from
Jul 30, 2024
Merged

fix(npm): don't break on npm workspace dir with a period #30483

merged 4 commits into from
Jul 30, 2024

Commits on Jul 30, 2024

  1. fix(npm): don't break on npm workspace dir with a period 

    When updating from the root folder, `lockFileDir` is '.'. The previous
path normalization would break an npm workspaceDir that happened to have
a period in it (e.g. "packages/foo.bar"), resulting in the
`npm install ... --workspace=...` command breaking with:

    npm error No workspaces found:\nnpm error   --workspace=packages/foobar

Fixes: renovatebot#30466
    @trentm
    trentm committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0f0341e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into tm-fix-npm-workspace-dir-with-period

    @trentm
    trentm committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    202c59c View commit details
    Browse the repository at this point in the history

  3. run prettier-fix

    @trentm
    trentm committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    471a0db View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into tm-fix-npm-workspace-dir-with-period

    @trentm
    trentm committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2930af2 View commit details
    Browse the repository at this point in the history