Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helmfile): lock update for multidoc YAML #31698

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 30, 2024

Fixes #31651

Update Helmfile manager to handle multidoc YAMLs correctly.

  • Replace parseSingleYaml with parseYaml in lib/modules/manager/helmfile/artifacts.ts to handle multiple YAML documents.
  • Update the doc variable to handle multiple documents in the updateArtifacts function.
  • Add a test case in lib/modules/manager/helmfile/artifacts.spec.ts for updating the lockfile with a multidoc YAML.
  • Mock the parseYaml function to handle multiple documents in the test case.

For more details, open the Copilot Workspace session.

Fixes #31651

Update Helmfile manager to handle multidoc YAMLs correctly.

* Replace `parseSingleYaml` with `parseYaml` in `lib/modules/manager/helmfile/artifacts.ts` to handle multiple YAML documents.
* Update the `doc` variable to handle multiple documents in the `updateArtifacts` function.
* Add a test case in `lib/modules/manager/helmfile/artifacts.spec.ts` for updating the lockfile with a multidoc YAML.
* Mock the `parseYaml` function to handle multiple documents in the test case.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/renovatebot/renovate/issues/31651?shareId=XXXX-XXXX-XXXX-XXXX).
viceice
viceice previously approved these changes Sep 30, 2024
@rarkins rarkins added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 9d3b485 Oct 3, 2024
38 checks passed
@rarkins rarkins deleted the rarkins/fix/31651-helmfile-lock-update-multidoc branch October 3, 2024 08:43
github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Oct 3, 2024
##### [`v38.107.0](https://github.com/renovatebot/renovate/releases/tag/38.107.0)

##### Features

-   **deps:** update ghcr.io/renovatebot/base-image docker tag to v7.32.0 ([#31761](renovatebot/renovate#31761)) ([3339fb1](renovatebot/renovate@3339fb1))
-   **deps:** update ghcr.io/renovatebot/base-image docker tag to v7.33.0 ([#31768](renovatebot/renovate#31768)) ([19b2dbf](renovatebot/renovate@19b2dbf))

##### Bug Fixes

-   **azure:** update cache after PR create or update ([#31766](renovatebot/renovate#31766)) ([6cfa52e](renovatebot/renovate@6cfa52e))
-   **helmfile:** lock update for multidoc YAML ([#31698](renovatebot/renovate#31698)) ([9d3b485](renovatebot/renovate@9d3b485))
-   **util/yaml:** increase max alias count ([#31758](renovatebot/renovate#31758)) ([084b90d](renovatebot/renovate@084b90d))

##### Miscellaneous Chores

-   **actions:** close invalid bugs ([#31765](renovatebot/renovate#31765)) ([93bf101](renovatebot/renovate@93bf101))
-   **deps:** update dependency [@types/node](https://github.com/types/node) to v20.16.8 ([#31759](renovatebot/renovate#31759)) ([95f4cfa](renovatebot/renovate@95f4cfa))
-   **deps:** update dependency [@types/node](https://github.com/types/node) to v20.16.9 ([#31764](renovatebot/renovate#31764)) ([08a4b10](renovatebot/renovate@08a4b10))
-   **deps:** update ghcr.io/containerbase/devcontainer docker tag to v12.0.1 ([#31760](renovatebot/renovate#31760)) ([49c54bd](renovatebot/renovate@49c54bd))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helmfile lock update fails if helmfile.yaml is multidoc
3 participants