Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(composer): ignorePlatformReqs #5937

Merged
merged 10 commits into from
Apr 11, 2020
Merged

feat(composer): ignorePlatformReqs #5937

merged 10 commits into from
Apr 11, 2020

Conversation

bytestream
Copy link
Contributor

Config option to prevent --ignore-platform-reqs in composer package manager

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bytestream bytestream changed the title Config option to prevent --ignore-platform-reqs in composer package manager feat: Config option to prevent --ignore-platform-reqs in composer package manager Apr 9, 2020
@bytestream
Copy link
Contributor Author

I'm not familiar with Typescript, so you'll have to point me in the right direction to fix those tests...

@JamieMagee
Copy link
Contributor

@bytestream You need to update the snapshots. You can do that by running yarn jest -u.

@bytestream
Copy link
Contributor Author

Thanks @JamieMagee should be OK now.

@rarkins
Copy link
Collaborator

rarkins commented Apr 11, 2020

@bytestream does this automatically close any of our existing issues? If so, please add Closes #12345 to the PR description.

@bytestream
Copy link
Contributor Author

No, it relates to #2355 and #4396 but it doesn't fix either of them.

@rarkins rarkins changed the title feat: Config option to prevent --ignore-platform-reqs in composer package manager feat(composer): ignorePlatformReqs Apr 11, 2020
@rarkins rarkins merged commit 5dea0a9 into renovatebot:master Apr 11, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.205.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bytestream
Copy link
Contributor Author

Thanks guys 👏

@bytestream bytestream deleted the ignore-platform-reqs branch April 11, 2020 09:56
This was referenced Apr 11, 2020
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bytestream @CLAassistant @JamieMagee @rarkins @renovate-release @viceice