Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): AppKit Auth #2413

Open
wants to merge 97 commits into
base: main
Choose a base branch
from
Open

feat(auth): AppKit Auth #2413

wants to merge 97 commits into from

Conversation

Cali93
Copy link
Collaborator

@Cali93 Cali93 commented Jun 13, 2024 •
edited by enesozturk
Loading

Context

Introduces AppKit Auth.
Notable changes:

  • chains has been removed from getMessageParams, we're relying on the chains provided to the connector
  • By using enableAuth: true developers don't need to provide a siweConfig. A default config is used instead.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@vercel Vercel
Copy link

vercel bot commented Jun 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new ❌ Failed (Inspect) Nov 20, 2024 9:04am
appkit-laboratory ✅ Ready (Inspect) Visit Preview Nov 20, 2024 9:04am
appkit-vue-solana ❌ Failed (Inspect) Nov 20, 2024 9:04am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 9:04am
vue-wagmi-example ❌ Failed (Inspect) Nov 20, 2024 9:04am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Nov 20, 2024 9:04am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Nov 20, 2024 9:04am

@Cali93 Cali93 marked this pull request as draft June 13, 2024 07:57
@tomiir @enesozturk
@bkrem @svenvoskamp @lukaisailovic
release: v5.0.2 (#2439)
f1261de 
Co-authored-by: Enes <[email protected]>
Co-authored-by: Ben Kremer <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Luka Isailovic <[email protected]>
@Cali93 Cali93 force-pushed the feat/appkit-auth branch from 15c37a9 to 3a1ca63 Compare June 19, 2024 08:37
@Cali93 Cali93 changed the base branch from main to V5 June 19, 2024 08:40
@Cali93 Cali93 marked this pull request as ready for review June 19, 2024 08:53
enesozturk
enesozturk reviewed Jun 19, 2024
View reviewed changes
apps/laboratory/src/pages/library/wagmi-siwe.tsx Outdated Show resolved Hide resolved
packages/common/src/utils/ConstantsUtil.ts Outdated Show resolved Hide resolved
packages/core/src/controllers/ApiController.ts Outdated Show resolved Hide resolved
packages/core/src/controllers/ApiController.ts Outdated Show resolved Hide resolved
packages/scaffold/src/client.ts Outdated Show resolved Hide resolved
packages/siwe/core/utils/AppKitAuthUtil.ts Outdated Show resolved Hide resolved
@tomiir @enesozturk
@bkrem @svenvoskamp @lukaisailovic
release: 5.0.3 (#2453)
9ce372e 
Co-authored-by: Enes <[email protected]>
Co-authored-by: Ben Kremer <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Luka Isailovic <[email protected]>
Co-authored-by: Ignacio Santise <[email protected]>
@Cali93 Cali93 force-pushed the feat/appkit-auth branch from 8785b5a to d7d055a Compare June 24, 2024 09:06
@Cali93 Cali93 force-pushed the feat/appkit-auth branch from d7d055a to ccb5067 Compare June 24, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enesozturk enesozturk enesozturk left review comments

@magiziz magiziz magiziz approved these changes

@tomiir tomiir tomiir approved these changes

@svenvoskamp svenvoskamp Awaiting requested review from svenvoskamp

@zoruka zoruka Awaiting requested review from zoruka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cali93 @bkrem @tomiir @enesozturk @magiziz