:feat refactor adapter clients #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fbef7e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomiir
reviewed
Nov 13, 2024
Comment on lines
+153
to
+157
| public async getEnsAddress( | ||
| params: AdapterBlueprint.GetEnsAddressParams | ||
| ): Promise<AdapterBlueprint.GetEnsAddressResult> { | ||
| return { address: params.name } | ||
| } |
There was a problem hiding this comment.
we should probably abstract a bit further (different PR) so that these things are kind of an extension to the blueprint rather than on the blueprint itself
tomiir
approved these changes
Nov 13, 2024
|
This is missing a changeset! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing new adapter foundation. All adapters will be handled through the adapter blueprint. All state will be handled on AppKit side.
Type of change
Associated Issues
Closes https://linear.app/reown/issue/APKT-1441/[bug]-not-showing-warningerrors-when-changing-manually-in-mm-to-a
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Todo