Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:fix swaps SA approval #3461

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

:fix swaps SA approval #3461

wants to merge 14 commits into from

Conversation

svenvoskamp
Copy link
Contributor

Description

Please include a brief summary of the change.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 866adb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-siwe Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:43pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:43pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:43pm
appkit-wagmi-cdn-example 🛑 Canceled (Inspect) Dec 13, 2024 2:43pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:43pm

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.96% 14793 / 27413
🔵 Statements 53.96% 14793 / 27413
🔵 Functions 40.79% 1063 / 2606
🔵 Branches 75.31% 1882 / 2499
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/ethers/src/client.ts 45.37% 51.78% 54.54% 45.37% 39-97, 113-114, 145-146, 159-182, 185-195, 208-244, 249-250, 257-274, 279-296, 299-320, 323-328, 338-339, 346-350, 373-380, 383-410, 414-415, 428-429, 431, 453-454, 458, 472, 483-485, 488-493, 496-500, 514-520, 542-544, 549-550, 552-557, 567-585, 591-592, 596-601, 610-611, 622-623
packages/adapters/ethers5/src/client.ts 43% 54% 54.54% 43% 40-98, 114-115, 146-147, 160-183, 186-196, 209-245, 250-251, 258-275, 280-297, 300-321, 324-329, 339-340, 347-351, 374-401, 404-411, 415-416, 429-430, 432, 457-458, 462, 476, 487-489, 492-497, 500-504, 518-524, 537-559, 567-585, 591-592, 596-601, 610-611, 622-623
packages/adapters/wagmi/src/client.ts 72.62% 56% 72.41% 72.62% 100-125, 146, 175-187, 192-195, 226, 228, 237, 259-260, 311-314, 319-320, 330-331, 399-414, 417-434, 443-444, 448-449, 466-476, 515, 519-522, 542-543, 549-550, 555-556, 560-565, 572-573, 579-580, 585-586, 595-596, 602-603, 608-609
packages/appkit/src/client.ts 19.09% 100% 0% 19.09% 186-193, 196-197, 200-235, 239-241, 244-246, 249-250, 254-255, 258-259, 262-271, 274-277, 280-283, 286-287, 290-291, 294-295, 298-300, 303-304, 307-308, 311-313, 316-317, 320-321, 324-335, 338-347, 350-351, 354-355, 358-359, 362-363, 366-367, 370-371, 374-375, 378-379, 382-383, 386-387, 390-391, 394-395, 398-399, 402-403, 406-409, 614-615, 618-621, 624-625, 628-629, 632-633, 636-637, 640-641, 645-732, 735-746, 749-769, 772-778, 781-790, 793-1125, 1128-1129, 1132-1264, 1267-1293, 1296-1364, 1367-1376, 1379-1389, 1392-1470, 1473-1493, 1496-1507, 1510-1535, 1541-1562, 1565-1604, 1607-1650, 1653-1664, 1667-1679, 1682-1722, 1725-1726, 1729-1738, 1741-1758, 1761-1781, 1784-1793, 1796-1812, 1815-1865, 1868-1879, 1882-1892, 1895-1911
packages/appkit/src/adapters/ChainAdapterBlueprint.ts 45.63% 70% 45.45% 45.63% 86-87, 94-103, 110-119, 127-146, 151-152, 161-162, 171-176, 185-189, 200-201
packages/common/src/contracts/swap.ts 100% 100% 100% 100%
packages/common/src/utils/ContractUtil.ts 60% 100% 0% 60% 9-13
packages/core/src/controllers/SendController.ts 25.68% 100% 35.48% 25.68% 52, 56, 84, 88, 92, 96-107, 111-154, 158-209, 213-248, 252-276, 274
packages/core/src/controllers/SwapController.ts 47.59% 64.7% 56.89% 47.59% 40-43, 166, 170, 180-181, 211-216, 242, 249-251, 260-261, 269-283, 287-299, 311, 315, 320-321, 329-332, 365, 372, 377-395, 405-407, 420-421, 432-433, 445, 452-453, 457-465, 493-494, 516-517, 531, 540-578, 582-639, 643-693, 698-750, 754-839, 856, 469-475, 855
Generated in workflow #8119 for commit 866adb6 by the Vitest Coverage Report Action

caipNetwork: CaipNetwork
provider?: AppKitConnector['provider']
caipAddress: CaipAddress
// eslint-disable-next-line @typescript-eslint/no-explicit-any
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this if unused

Comment on lines +935 to +938
const provider = ProviderUtil.getProvider(
ChainController.state.activeChain as ChainNamespace
)
const result = await adapter?.sendTransaction({ ...args, provider })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this change needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants