Bump pydantic to get bugfix! #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #65 for context, or pydantic/pydantic-core#1332 directly. The issue we were seeing was specifically around union decoders failing to decode properties of the selected variant, so even though we'd get the right model it wouldn't be filled out.
blast-hardcheese
requested review from
masad-frost
and removed request for
a team
masad-frost
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
See #65 for context, or pydantic/pydantic-core#1332 directly.
The issue we were seeing was specifically around union decoders failing to decode properties of the selected variant, so even though we'd get the right model it wouldn't be filled out.
What changed
Bump pydantic to the latest released beta
Test plan
Run codegen, observe that the generated code matches the previously generated code to a reasonable degree.