Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HA_ACTIVE: True to enable HA mode #7493

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

Vasfed
Copy link
Contributor

@Vasfed Vasfed commented Dec 29, 2024

When something python-like (carvel ytt, ansible etc.) is used in deploying wiki - it is highly likely to have a construction similar to:

      env:
        - name: HA_ACTIVE
          value: #@ str(data.values.replicas > 1)

which produces "True" in config and counter-intuitively does not enable high-availability mode, leading to corresponding issues with caching (page edits not reflected until a lot of refreshes, randomly returning stale pages and so on - because not all workers actually refresh the page cache)

With this simple edit we can significantly decrease user frustration

@auto-assign auto-assign bot requested a review from NGPixel December 29, 2024 11:28
@NGPixel NGPixel merged commit abc8dce into requarks:main Jan 1, 2025
@NGPixel
Copy link
Member

NGPixel commented Jan 1, 2025

I changed the logic to allow any casing for a string value.

However, if you plan on using Wiki.js in a high-availability environment, regardless of whether the replicas count is 1 or higher, HA_ACTIVE should always be set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants