Linkedin compliance removal & LinkedIn Example update/fix #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtroussard
added
bug
clean-up
singingwolfboy
requested changes
Feb 17, 2020
docs/examples/linkedin.rst
Outdated
|
|
||
| >>> # Fetch the access token | ||
| >>> linkedin.fetch_token(token_url, client_secret=client_secret, | ||
| ... authorization_response=redirect_response) | ||
| >>> linkedin.fetch_token(token_url,client_secret=client_secret,include_client_id=True,authorization_response=redirect_response) |
There was a problem hiding this comment.
Can you break this across multiple lines? It's hard to read all on one line like this.
There was a problem hiding this comment.
No problem. This file as a whole is weird to me. Not sure why it was made into an .rst, and even if it's something the OC wanted documented this is sort of a pain to edit. Perhaps as a back log item for this could be to reformat these examples so that they render well in documentation yet are more user friendly e.g. pull down and hit play.
First I'm seeing f strings. I've always been happy with format method, but I'll check the docs and give these a whirl. Co-Authored-By: David Baumgold <[email protected]>
…ests/requests-oauthlib into linkedin-compliance-removal
docs/examples/linkedin.rst
Outdated
|
|
||
| >>> # Fetch the access token | ||
| >>> linkedin.fetch_token(token_url, client_secret=client_secret, | ||
| >>> linkedin.fetch_token(token_url,client_secret=client_secret, |
There was a problem hiding this comment.
More more nitpick: you dropped a space here, which makes it less readable
singingwolfboy
approved these changes
Feb 17, 2020
This was referenced Feb 17, 2020
Closed
This was referenced Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an extension/revision of PR #388 - Upon further review and testing it has been determined that LinkedIn's API as it stands is in compliance and the compliance fixes were introducing errors in certain scenarios related to appending token codes to resource request URLs.
In short this PR includes: