Remove some too frequent profile scopes (causing profiler slowdown fo…

…r many-entities) (#8414)

The usual whack-a-mole: profiler scopes themselves cause as more
overhead than what they're profiling, causing puffing traces to be a lot
less useful:


recording of revy's `alien_cake_addict`

Before (main):
<img width="1309" alt="image"
src="https://github.com/user-attachments/assets/541ace08-964a-4076-aa18-4e87d476e317"
/>


After:
<img width="1303" alt="image"
src="https://github.com/user-attachments/assets/f8cdfe26-99b7-4c50-a791-b7d445375ba4"
/>


Puffing no longer warns but there's still quite some overhead: It makes
the reported cpu time go up from ~52ms to ~57ms
Well, time to call less methods - afaik a lot is caused by blueprint
queries that we _know_ will turn up empty! (one of the next things I'm
looking into)

crates/store/re_query/src/latest_at.rs

@@ -48,7 +48,7 @@ impl QueryCache {
         entity_path: &EntityPath,
         component_descrs: impl IntoIterator<Item = impl Into<Cow<'d, ComponentDescriptor>>>,
     ) -> LatestAtResults {
-        re_tracing::profile_function!(entity_path.to_string());
+        // This is called very frequently, don't put a profile scope here.
 
         let store = self.store.read();
 
@@ -87,8 +87,6 @@ impl QueryCache {
         // the data.
         let mut max_clear_index = (TimeInt::MIN, RowId::ZERO);
         {
-            re_tracing::profile_scope!("clears");
-
             let potential_clears = self.might_require_clearing.read();
 
             let mut clear_entity_path = entity_path.clone();

crates/viewer/re_view/src/query.rs

@@ -85,7 +85,7 @@ pub fn latest_at_with_blueprint_resolved_data<'a>(
     component_names: impl IntoIterator<Item = ComponentName>,
     query_shadowed_defaults: bool,
 ) -> HybridLatestAtResults<'a> {
-    re_tracing::profile_function!(data_result.entity_path.to_string());
+    // This is called very frequently, don't put a profile scope here.
 
     let mut component_set = component_names.into_iter().collect::<IntSet<_>>();
 

crates/viewer/re_view/src/results_ext.rs

@@ -135,7 +135,7 @@ pub enum HybridResults<'a> {
 
 impl HybridResults<'_> {
     pub fn query_result_hash(&self) -> Hash64 {
-        re_tracing::profile_function!();
+        // This is called very frequently, don't put a profile scope here.
         // TODO(andreas): We should be able to do better than this and determine hashes for queries on the fly.
 
         match self {

crates/viewer/re_view_spatial/src/contexts/transform_context.rs

@@ -734,7 +734,7 @@ fn transforms_at(
     pinhole_image_plane_distance: impl Fn(&EntityPath) -> f32,
     encountered_pinhole: &mut Option<EntityPath>,
 ) -> Result<TransformsAtEntity, UnreachableTransformReason> {
-    re_tracing::profile_function!();
+    // This is called very frequently, don't put a profile scope here.
 
     let potential_transform_components =
         TransformComponentTrackerStoreSubscriber::access(&entity_db.store_id(), |tracker| {

crates/viewer/re_view_spatial/src/mesh_cache.rs

@@ -56,8 +56,6 @@ impl MeshCache {
         mesh: AnyMesh<'_>,
         render_ctx: &RenderContext,
     ) -> Option<Arc<LoadedMesh>> {
-        re_tracing::profile_function!();
-
         self.0
             .entry(key.versioned_instance_path_hash.row_id)
             .or_default()

crates/viewer/re_viewport_blueprint/src/view_contents.rs

@@ -393,8 +393,6 @@ impl DataQueryPropertyResolver<'_> {
 
                 // Update visualizers from overrides.
                 if !node.data_result.visualizers.is_empty() {
-                    re_tracing::profile_scope!("Update visualizers from overrides");
-
                     // If the user has overridden the visualizers, update which visualizers are used.
                     if let Some(viz_override) = blueprint
                         .latest_at_component::<VisualizerOverrides>(
@@ -524,7 +522,7 @@ impl DataQueryPropertyResolver<'_> {
         query_result: &mut DataQueryResult,
         view_states: &mut ViewStates,
     ) {
-        re_tracing::profile_function!();
+        // This is called very frequently, don't put a profile scope here.
 
         if let Some(root) = query_result.tree.root_handle() {
             let recursive_property_overrides = Default::default();