Skip to content

Commit

Permalink
fix todo comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Wumpf committed Dec 15, 2023
1 parent 8c54a4d commit d01ffea
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ struct VisualizerTypeRegistryEntry {

impl Drop for VisualizerTypeRegistryEntry {
fn drop(&mut self) {
// TODO: Not yet implemented.
// TODO(andreas): DataStore unsubscribe is not yet implemented!
//DataStore::unregister_subscriber(self.entity_subscriber_handle);
}
}
Expand Down
4 changes: 2 additions & 2 deletions crates/re_viewport/src/space_view_heuristics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ pub fn identify_entities_per_system_per_class(
let mut entities_per_system = EntitiesPerSystem::default();
let class_id = entry.class.identifier();

// TODO(andreas/jleibs): Once `heuristic_filter` is no longer applied, we don't need to instantiate the systems anymore.
// TODO(andreas): Once `heuristic_filter` is no longer applied, we don't need to instantiate the systems anymore.
//for system_id in &entry.visualizer_system_ids {
for (system_id, system) in space_view_class_registry
.new_part_collection(class_id)
Expand All @@ -568,7 +568,7 @@ pub fn identify_entities_per_system_per_class(
let entities: IntSet<EntityPath> = if let Some(entities) = space_view_class_registry
.applicable_entities_for_visualizer_system(system_id, store)
{
// TODO(andreas/jleibs): Don't apply heuristic_filter here, this should be part of the query!
// TODO(andreas): Don't apply heuristic_filter here, this should be part of the query!
// Note that once this is done, `EntitiesPerSystemPerClass` becomes just `EntitiesPerSystem` since there's never a need to distinguish per class!
entities
.into_iter()
Expand Down

0 comments on commit d01ffea

Please sign in to comment.