Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup_native_logging needs to handle its own Once semantics #4893

Closed
teh-cmc opened this issue Jan 23, 2024 · 0 comments · Fixed by #4896
Closed

setup_native_logging needs to handle its own Once semantics #4893

teh-cmc opened this issue Jan 23, 2024 · 0 comments · Fixed by #4896
Assignees
@teh-cmc
Labels
😤 annoying Something in the UI / SDK is annoying to use 🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less 🚜 refactor Change the code, not the functionality

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jan 23, 2024

Everything that calls into setup_native_logging (which is a lot) has to take care of wrapping it in Once-like semantics.

Let's implement these semantics in setup_native_logging directly.
@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 😤 annoying Something in the UI / SDK is annoying to use 🚜 refactor Change the code, not the functionality labels Jan 23, 2024
@teh-cmc teh-cmc mentioned this issue Jan 23, 2024
Merged
4 tasks
@teh-cmc teh-cmc self-assigned this Jan 23, 2024
@emilk emilk added the 🏎️ Quick Issue Can be fixed in a few hours or less label Jan 24, 2024
@teh-cmc teh-cmc mentioned this issue Jan 24, 2024
Merged
4 tasks
teh-cmc added a commit that referenced this issue Jan 24, 2024
@teh-cmc
Once semantics for setup_{web|native}_logging (#4896)
639b271 
- Fixes #4893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
😤 annoying Something in the UI / SDK is annoying to use 🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Once semantics for setup_{web|native}_logging rerun-io/rerun
2 participants
@emilk @teh-cmc