Fix clipboard on X11 #264
Merged
Fix clipboard on X11 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 48f866c.
teh-cmc
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
This does fix the error logs on Linux, and I do see a success message when copying an image to the clipboard (INFO re_viewer::misc::clipboard: Image copied to clipboard).
Though, in practice, there doesn't seem to be anything in my clipboard... 🤷♂️ .
In any case, this is an improvement over the status quo and probably not something on our end.
(Btw, I would have never found the "Copy to clipboard" button without checking the code 😬 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 1Password/arboard#88 and 1Password/arboard#89
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)