-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Blueprint types to be full Archetype/Components within a scoped namespace #4477
Conversation
f2a2bdc
to
94b6d8b
Compare
94b6d8b
to
d8d2c66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One oddity in the C++ output but other than that I think this looks as expected. 🥵
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rerun/blueprint/blueprint
, something went wrong... is this some orphaned thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, yes, that was one of the things that got fixed later in the stack but I failed to commit the removal. Thanks for catching.
What
Blueprint code will benefit from being able to leverage the same Archetype / Component patterns as our other datatypes.
Rather than treating Blueprint as an alternative ObjectKind this now uses a
blueprint
scope for the given blueprint types. This had some obnoxious fan-out to clean up all of the C++ header / include / namespace / python import stuff.Probably best reviewed commit by commit.
Checklist