Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure main is included in nightly builds #4546

Merged
merged 1 commit into from
Dec 15, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion crates/re_build_examples/src/example.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,15 @@ pub enum Channel {
}

impl Channel {
pub fn includes(self, other: Channel) -> bool {
match self {
Channel::Main => matches!(other, Channel::Main),

// Include all `main` examples in `nightly`
Channel::Nightly => matches!(other, Channel::Main | Channel::Nightly),
}
}

pub fn examples(self) -> anyhow::Result<Vec<Example>> {
let mut examples = vec![];
let dir = Path::new("examples/python");
Expand Down Expand Up @@ -59,7 +68,7 @@ impl Channel {
continue;
};

if channel != self {
if !self.includes(channel) {
eprintln!("{name:?}: skipped");
continue;
}
Expand Down
Loading