Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track crate dependency count over time #5228

Merged
merged 16 commits into from
Feb 21, 2024
Merged

Track crate dependency count over time #5228

merged 16 commits into from
Feb 21, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 19, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 19, 2024
@jprochazk
Copy link
Member

TODO:

  • the bash expression to count dependencies is undercounting

Copy link

github-actions bot commented Feb 19, 2024

Size changes

Name main 5228/merge Change
re_sdk --no-default-features (none) 117 crates +100%
re_viewer --all-features (none) 408 crates +100%
rerun --all-features (none) 435 crates +100%

@emilk
Copy link
Member Author

emilk commented Feb 20, 2024

The undercounting might be because we don't count build-dependencies 🤔

@emilk
Copy link
Member Author

emilk commented Feb 20, 2024

The dependency count is off by quite a lot, but maybe this is still a good start.

cargo check -p re_sdk --no-default-features says 213 deps
scripts/ci/count_dependencies.py -p re_sdk --no-default-features says 118
cargo deps-list -p re_sdk --no-default-features says 165

cargo check -p re_viewer --all-features says 504
scripts/ci/count_dependencies.py -p re_viewer --all-features says 329
cargo deps-list -p re_viewer --all-features says 368

Importantly, adding e.g. meilisearch-sdk = "0.24.3" to a Cargol.toml makes the count jump by 59, which should be a strong warning signal.

@emilk emilk marked this pull request as ready for review February 20, 2024 14:22
@jprochazk
Copy link
Member

Can we try to compare against what this outputs? https://docs.rs/crate/cargo-deps-list/latest

@emilk emilk merged commit 2625247 into main Feb 21, 2024
40 checks passed
@emilk emilk deleted the emilk/track-dependencies branch February 21, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track compile-times and dependency count of rerun-sdk over time
2 participants