Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin mimalloc to 0.1.37 #5874

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Pin mimalloc to 0.1.37 #5874

merged 3 commits into from
Apr 9, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Apr 9, 2024 •
edited
Loading

mimalloc starts leaking OS pages starting with 0.1.38.

We don't know the full story yet, but for now we want to focus on shipping 0.15 and then we can investigate all of that calmly.

TODO:

  • (Linux) cherry pick on 0.15 and check that it fixes the leak
  • (MacOS) cherry pick on 0.15 and check that it fixes the leak

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@teh-cmc teh-cmc added 🪳 bug Something isn't working 🚀 performance Optimization, memory use, etc dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 9, 2024
@teh-cmc teh-cmc mentioned this pull request Apr 9, 2024
Closed
@teh-cmc teh-cmc force-pushed the cmc/mimalloc_revert branch from 9b6cccc to 61dc0b2 Compare April 9, 2024 13:53
@teh-cmc teh-cmc merged commit c97ee89 into main Apr 9, 2024
24 of 27 checks passed
@teh-cmc teh-cmc deleted the cmc/mimalloc_revert branch April 9, 2024 13:55
teh-cmc added a commit that referenced this pull request Apr 9, 2024
@teh-cmc
Pin mimalloc to 0.1.37 (#5874)
adb34f5 
`mimalloc` starts leaking OS pages starting with `0.1.38`.

We don't know the full story yet, but for now we want to focus on
shipping 0.15 and then we can investigate all of that calmly.
@abey79 abey79 mentioned this pull request Apr 11, 2024
Closed
@teh-cmc teh-cmc mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md 🚀 performance Optimization, memory use, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @abey79