Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ChunkStore and integrate it everywhere #6570

Merged
merged 10 commits into from
Jul 4, 2024
Merged

Implement ChunkStore and integrate it everywhere #6570

merged 10 commits into from
Jul 4, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jun 13, 2024 •
edited by github-actions bot
Loading

Implements the new chunk store and integrates it all over the place.

The highest-level query APIs and caches are unchanged -- for now.

Requires 0.17 to be branched off of main before merging.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added the do-not-merge Do not merge this PR label Jun 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

Deployed docs

Commit Link
6b42567 https://landing-1mhz4bqec-rerun.vercel.app/docs

@teh-cmc teh-cmc force-pushed the cmc/store_chunks_scratch branch from d647ab2 to d27cbd5 Compare June 13, 2024 16:59
@rerun-io rerun-io deleted a comment from github-actions bot Jun 13, 2024
@rerun-io rerun-io deleted a comment from github-actions bot Jun 13, 2024
@teh-cmc teh-cmc force-pushed the cmc/store_chunks_scratch branch from d27cbd5 to 83d9019 Compare June 13, 2024 17:13
@rerun-io rerun-io deleted a comment from github-actions bot Jun 13, 2024
@teh-cmc teh-cmc mentioned this pull request Jun 14, 2024
Open
@teh-cmc teh-cmc force-pushed the cmc/store_chunks_scratch branch 8 times, most recently from b38a0e9 to 801ef7e Compare June 17, 2024 15:55
@rerun-io rerun-io deleted a comment from github-actions bot Jun 17, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Jun 17, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/9550919972

@teh-cmc teh-cmc force-pushed the cmc/store_chunks_scratch branch from 801ef7e to 06f9efb Compare June 17, 2024 16:19
@teh-cmc teh-cmc changed the base branch from main to cmc/read_time_clears June 17, 2024 16:27
@teh-cmc teh-cmc force-pushed the cmc/store_chunks_scratch branch 3 times, most recently from a8e7f95 to 239c1b4 Compare June 17, 2024 16:49
@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 🚀 performance Optimization, memory use, etc include in changelog labels Jun 17, 2024
@teh-cmc teh-cmc force-pushed the cmc/store_chunks_scratch branch from 239c1b4 to 28a8415 Compare June 18, 2024 08:03
@teh-cmc teh-cmc marked this pull request as ready for review June 18, 2024 08:13
@teh-cmc teh-cmc force-pushed the cmc/read_time_clears branch from bcdb2a4 to 787a1eb Compare June 18, 2024 08:39
jleibs
jleibs approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like how this turned out. Very nice work.

crates/re_chunk_store/src/query.rs Outdated Show resolved Hide resolved
crates/re_chunk_store/src/query.rs Outdated Show resolved Hide resolved
crates/re_chunk_store/src/query.rs Outdated Show resolved Hide resolved
crates/re_entity_db/src/entity_db.rs Show resolved Hide resolved
@teh-cmc teh-cmc mentioned this pull request Jun 24, 2024
Closed
@teh-cmc teh-cmc force-pushed the cmc/read_time_clears branch from 5993e19 to ab759fe Compare July 1, 2024 08:58
@teh-cmc teh-cmc force-pushed the cmc/store_chunks_scratch branch from 7e789be to 1e24a6b Compare July 1, 2024 09:47
@teh-cmc
Copy link
Member Author

teh-cmc commented Jul 1, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/9745909133

@teh-cmc teh-cmc force-pushed the cmc/read_time_clears branch from ab759fe to f509c85 Compare July 4, 2024 13:14
@teh-cmc teh-cmc force-pushed the cmc/store_chunks_scratch branch from 56207f3 to 6b42567 Compare July 4, 2024 13:39
@teh-cmc teh-cmc changed the title Chunk store waiting room Implement ChunkStore and integrate it everywhere Jul 4, 2024
Base automatically changed from cmc/read_time_clears to main July 4, 2024 15:14
@teh-cmc teh-cmc force-pushed the cmc/store_chunks_scratch branch from 6b42567 to d304e97 Compare July 4, 2024 15:15
@teh-cmc teh-cmc merged commit ed20cba into main Jul 4, 2024
18 of 19 checks passed
@teh-cmc teh-cmc deleted the cmc/store_chunks_scratch branch July 4, 2024 15:15
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jul 4, 2024
Wumpf
Wumpf reviewed Oct 18, 2024
View reviewed changes
examples/rust/dna/src/main.rs
@@ -12,7 +12,8 @@ use rerun::{
const NUM_POINTS: usize = 100;

fn main() -> Result<(), Box<dyn std::error::Error>> {
let rec = rerun::RecordingStreamBuilder::new("rerun_example_dna_abacus").spawn()?;
let rec = rerun::RecordingStreamBuilder::new("rerun_example_dna_abacus")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like whoopsi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf left review comments

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
include in changelog 🚀 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself
Projects
None yet
Milestone
No milestone
3 participants
@teh-cmc @Wumpf @jleibs