Fix formatting of RowId/Tuid when printing ChunkStore #8656
+129
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🏹 arrow
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
force-pushed
the
emilk/fix-tuid-arrow-formatting
branch
from
38f4aef to
64b0be5
Compare
emilk
commented
Jan 11, 2025
|
|
||
| #[cfg(not(target_arch = "wasm32"))] // requires TTY | ||
| { | ||
| cell.add_attribute(comfy_table::Attribute::Italic) |
There was a problem hiding this comment.
I had to remove the italics, otherwise the formatting was different locally (tty) and on CI
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12742851153 |
teh-cmc
force-pushed
the
emilk/fix-tuid-arrow-formatting
branch
from
f0c925e to
4ffb4e8
Compare
teh-cmc
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a regression test
re_arrow2toarrow#3741