Make Image & Mesh3D archetypes in Rust eager serialized
#8793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
oops, some todos left in there that indicate I wanted to test some stuff there first |
|
indeed testing with |
emilk
approved these changes
Jan 24, 2025
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12947591433 |
teh-cmc
pushed a commit
that referenced
this pull request
Jan 24, 2025
### Related * sister PR to.. * #8789 * #8785 * #8793 * missed piece of #7245 ### What Ports the Tensor archetype in rust to the new eager serialized interface. Unfortunately this meant I had to remove some direct access methods of the underlying tensor data. Curiously, this didn't affect any of our test/snippet/example code. While doing so I also fixed some wording issues in the (very similar) C++ implementation of `with_dim_names`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Pinholearchetype in Rust eager serialized #8789Box/AssetVideo/ViewCoordinates/Asset3Deager serialized in Rust #8785What
Similar to the previous PRs. These two had a few touching points, so this comes in bulk.
Led actually to a few nice cleanups around Meshes. Image cache on the other hand got a little bit hairy, resolved this by moving some extensions from the archetype down to the components.
No breaking changes & deprecations.
Next step: Remove
"attr.rust.archetype_eager", making this always on.