Expose creating and querying index for a ReDap collection in python SDK #8890
+561
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zehiko
added
exclude from changelog
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
jleibs
approved these changes
Feb 3, 2025
examples/python/remote/metadata.py
Outdated
| @@ -68,3 +72,8 @@ | |||
| schema = conn.get_recording_schema(id) | |||
| for column in schema: | |||
| print(column) | |||
| elif args.subcommand == "create-index": | |||
There was a problem hiding this comment.
Suggested change
| elif args.subcommand == "create-index": | |
| elif args.subcommand == "create-vector-index": |
examples/python/remote/metadata.py
Outdated
| @@ -68,3 +72,8 @@ | |||
| schema = conn.get_recording_schema(id) | |||
| for column in schema: | |||
| print(column) | |||
| elif args.subcommand == "create-index": | |||
| column = rr.dataframe.ComponentColumnSelector(args.entity_path, args.index_column) | |||
| index = rr.dataframe.IndexColumnSelector("log_tick") | |||
There was a problem hiding this comment.
Might as well make this and the collection name configurable as well.
| column, | ||
| top_k, | ||
| ))] | ||
| fn query_vector_index( |
There was a problem hiding this comment.
I'm realizing here and elsewhere that query isn't really the right term. Propose we swap this with "search":
https://github.com/rerun-io/dataplatform/issues/185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Basic plumbing that enables creating and querying vector and FTS index. Joint effort from @jleibs and me.
Testing done
Ran the latest
Indexingnotebook successfully.