More Viewer control in notebooks (recording id, panel states) #8917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
jprochazk
commented
Feb 4, 2025
| @@ -190,6 +197,78 @@ def _repr_mimebundle_(self, **kwargs: dict) -> tuple[dict, dict] | None: # type | |||
| def _repr_keys(self): # type: ignore[no-untyped-def] | |||
| return self._viewer._repr_keys() | |||
|
|
|||
| def update_panels( | |||
There was a problem hiding this comment.
A "partial update" API felt the most intuitive to me. This means that we need a way to differentiate between "don't update this panel state" (None) and "please reset this panel state" (default).
jleibs
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
set_active_recording_id#8874set_time_ctrl#8894What
This PR introduces the following notebook-only APIs:
Viewer.set_active_recording, allowing the user to programmatically choose the active recording in multi-recording scenarios.Viewer.update_panels, exposing the ability to partially update the state of panels.use_global_recordingparam in thererun.notebook.Viewerconstructor, which allows theViewerto be displayed in a "clean" state, without implicitly capturing any data from any recording. Recordings can then be added later using the existingViewer.add_recordingmethod.I also discovered that our build script was subtly broken for a while now 😬 specifically, the
CLOSURE_DTORSfinalizer would throw an exception becausewasmwasnull. Luckily it didn't cause any issues except for there being some error spam in the console.