Fix NavigationContainer ref type #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimapaloskin
changed the title
MoOx
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
Looks good to me, but I will ask for @Freddy03h review because he added this ref. I would like a confirmation that this change is ok as I don't use this ref (yet).
|
@MoOx @Freddy03h any updates? :) |
Freddy03h
approved these changes
Feb 13, 2021
|
Sorry for the delay! |
|
Hi @MoOx ! I merged the PR because I've already approved it. What do you think about release a new version? |
|
Published as 5.1.0 with rescript breaking changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Looks like
NavigationContainerref hasNavigationContainerReftype: packages/native/src/NavigationContainer.tsx#L47These changes will make it possible to use navigation without
navigationprop.