fix: assorted non-fatal clippy warnings (#274)

brush-core/src/completion.rs

@@ -891,11 +891,7 @@ impl Config {
         simple_tokenize_by_delimiters(input, &default_delimiters)
     }
 
-    async fn get_completions_for_token<'a>(
-        &self,
-        shell: &mut Shell,
-        context: Context<'a>,
-    ) -> Answer {
+    async fn get_completions_for_token(&self, shell: &mut Shell, context: Context<'_>) -> Answer {
         // See if we can find a completion spec matching the current command.
         let mut found_spec: Option<&Spec> = None;
 

brush-core/src/expansion.rs

@@ -343,6 +343,7 @@ impl<'a> WordExpander<'a> {
         Ok(expanded)
     }
 
+    #[allow(clippy::ref_option)]
     async fn basic_expand_opt_pattern(
         &mut self,
         word: &Option<String>,
@@ -1337,6 +1338,7 @@ impl<'a> WordExpander<'a> {
     }
 
     #[allow(clippy::unwrap_in_result)]
+    #[allow(clippy::ref_option)]
     fn uppercase_first_char(
         s: String,
         pattern: &Option<patterns::Pattern>,
@@ -1362,6 +1364,7 @@ impl<'a> WordExpander<'a> {
     }
 
     #[allow(clippy::unwrap_in_result)]
+    #[allow(clippy::ref_option)]
     fn lowercase_first_char(
         s: String,
         pattern: &Option<patterns::Pattern>,
@@ -1386,6 +1389,7 @@ impl<'a> WordExpander<'a> {
         }
     }
 
+    #[allow(clippy::ref_option)]
     fn uppercase_pattern(
         s: &str,
         pattern: &Option<patterns::Pattern>,
@@ -1405,6 +1409,7 @@ impl<'a> WordExpander<'a> {
         }
     }
 
+    #[allow(clippy::ref_option)]
     fn lowercase_pattern(
         s: &str,
         pattern: &Option<patterns::Pattern>,

brush-core/src/interp.rs

@@ -1259,8 +1259,8 @@ fn setup_pipeline_redirection(
 }
 
 #[allow(clippy::too_many_lines)]
-pub(crate) async fn setup_redirect<'a>(
-    open_files: &'a mut OpenFiles,
+pub(crate) async fn setup_redirect(
+    open_files: &'_ mut OpenFiles,
     shell: &mut Shell,
     redirect: &ast::IoRedirect,
 ) -> Result<Option<u32>, error::Error> {

brush-core/src/patterns.rs

@@ -394,6 +394,7 @@ fn pattern_to_regex_str(
 /// * `s` - The string to remove the prefix from.
 /// * `pattern` - The pattern to match.
 /// * `enable_extended_globbing` - Whether or not to enable extended globbing (extglob).
+#[allow(clippy::ref_option)]
 pub(crate) fn remove_largest_matching_prefix<'a>(
     s: &'a str,
     pattern: &Option<Pattern>,
@@ -416,6 +417,7 @@ pub(crate) fn remove_largest_matching_prefix<'a>(
 /// * `s` - The string to remove the prefix from.
 /// * `pattern` - The pattern to match.
 /// * `enable_extended_globbing` - Whether or not to enable extended globbing (extglob).
+#[allow(clippy::ref_option)]
 pub(crate) fn remove_smallest_matching_prefix<'a>(
     s: &'a str,
     pattern: &Option<Pattern>,
@@ -438,6 +440,7 @@ pub(crate) fn remove_smallest_matching_prefix<'a>(
 /// * `s` - The string to remove the suffix from.
 /// * `pattern` - The pattern to match.
 /// * `enable_extended_globbing` - Whether or not to enable extended globbing (extglob).
+#[allow(clippy::ref_option)]
 pub(crate) fn remove_largest_matching_suffix<'a>(
     s: &'a str,
     pattern: &Option<Pattern>,
@@ -460,6 +463,7 @@ pub(crate) fn remove_largest_matching_suffix<'a>(
 /// * `s` - The string to remove the suffix from.
 /// * `pattern` - The pattern to match.
 /// * `enable_extended_globbing` - Whether or not to enable extended globbing (extglob).
+#[allow(clippy::ref_option)]
 pub(crate) fn remove_smallest_matching_suffix<'a>(
     s: &'a str,
     pattern: &Option<Pattern>,

brush-interactive/src/reedline/refs.rs

@@ -11,7 +11,7 @@ pub(crate) struct ReedlineShellReader<'a> {
     pub shell: MutexGuard<'a, brush_core::Shell>,
 }
 
-impl<'a> AsRef<brush_core::Shell> for ReedlineShellReader<'a> {
+impl AsRef<brush_core::Shell> for ReedlineShellReader<'_> {
     fn as_ref(&self) -> &brush_core::Shell {
         self.shell.borrow()
     }
@@ -21,7 +21,7 @@ pub(crate) struct ReedlineShellWriter<'a> {
     pub shell: MutexGuard<'a, brush_core::Shell>,
 }
 
-impl<'a> AsMut<brush_core::Shell> for ReedlineShellWriter<'a> {
+impl AsMut<brush_core::Shell> for ReedlineShellWriter<'_> {
     fn as_mut(&mut self) -> &mut brush_core::Shell {
         self.shell.borrow_mut()
     }

brush-parser/src/parser.rs

@@ -130,7 +130,7 @@ pub fn parse_tokens(
     result
 }
 
-impl<'a> peg::Parse for Tokens<'a> {
+impl peg::Parse for Tokens<'_> {
     type PositionRepr = usize;
 
     #[inline]

brush-parser/src/tokenizer.rs

@@ -1139,7 +1139,7 @@ impl<'a, R: ?Sized + std::io::BufRead> Tokenizer<'a, R> {
     }
 }
 
-impl<'a, R: ?Sized + std::io::BufRead> Iterator for Tokenizer<'a, R> {
+impl<R: ?Sized + std::io::BufRead> Iterator for Tokenizer<'_, R> {
     type Item = Result<TokenizeResult, TokenizerError>;
 
     fn next(&mut self) -> Option<Self::Item> {