-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(completion): progress toward passing bash-completion test suite #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 35 out of 35 changed files in this pull request and generated no suggestions.
Test Results 2 files 9 suites 1m 17s ⏱️ Results for commit 7f0351b. ♻️ This comment has been updated with latest results. |
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
96a5e17
to
e61af91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 38 out of 38 changed files in this pull request and generated no suggestions.
e61af91
to
c4a3b70
Compare
c4a3b70
to
b4f81d8
Compare
b4f81d8
to
7f0351b
Compare
These changes are an assortment focused on being able to run the
bash-completion
pytest
/pexpect
-based test suite and increase our pass rate of its tests. Along the way a number of targeted fixes and additions were made to address compatibility issues identified as side effects of these tests.Upon initial execution of the tests we saw:
(
xfailed
means "expected failed".) I haven't done a full re-run of the tests, but expected the pass rate to be somewhat higher with these changes.Notable changes:
pexpect
and other standardpty
-based testing frameworks. This required a fair bit of fiddling to avoid use of VT100-style escape sequences as well as get the output to match what other shells emit.lastpipe
option.mapfile
built-in, required by some completion helper functions. The most notable constraint is that we only support\n
as a delimiter. There are other limitations as well, identified by calls toerror::unimp()
in the code.bind
built-in, emitting just enough to let some completion helper functions pass. Clearly more work is required here, as well as some thought as to which functions we can/should expose.