Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 2 + Build updates #40

Merged
merged 18 commits into from
Mar 6, 2017
Merged

Webpack 2 + Build updates #40

merged 18 commits into from
Mar 6, 2017

Conversation

zslabs
Copy link
Contributor

@zslabs zslabs commented Mar 3, 2017

What should this PR do?

Highlights are:

  • Upgrades both the doc/dist builds to use Webpack 2
  • Gulp watch updates for easier dev with component examples
  • Usedgulp-load-plugins to trim up gulp file.
  • Removes inline page script for modular approach to re-use GSAP and (new) resize listeners
  • Bundles CodeMirror with doc bundle, fixes multi-line selection
  • Updates several package.json dependencies
  • Updated webpack gulp task to use webpack-stream to work better with plugins we may want to use within the stream.
  • Removed boomsvgloader and rewrote as ES6 module within framework.

What is the acceptance criteria?

  1. Make sure that you can interact with components as you can now on the doc site (in-terms of the playground)
  2. Since we are just including the rhinostyle bundle in rhiniofront, I do not believe this work is dependent on rhinofront updates, but will want to take some time to review bundle size and functionality when pulled in to make sure there are no regressions.

Future work

  • Integrate eslint within this build process. I left this off as that will take a little bit to update all of the files to the standard we need
  • Separate out tasks to subfolders

…ild-updates

# Conflicts:
#	build/css/rhinostyle-docs.css
#	build/metalsmith-changed-ctimes.json
#	build/scripts/avatar.js
#	build/scripts/bucket.js
#	build/scripts/button.js
#	build/scripts/close.js
#	build/scripts/cover.js
#	build/scripts/datepicker.js
#	build/scripts/dropdown.js
#	build/scripts/feedback.js
#	build/scripts/form.js
#	build/scripts/icon.js
#	build/scripts/label.js
#	build/scripts/loader.js
#	build/scripts/message.js
#	build/scripts/modal.js
#	build/scripts/navigation.js
#	build/scripts/pill.js
#	build/scripts/progressbar.js
#	build/scripts/rhinostyle-docs.js
#	build/scripts/scrollbars.js
#	build/scripts/table.js
#	build/scripts/tabs.js
#	build/scripts/tooltips.js
#	build/scripts/utility-components.js
#	build/scripts/vendor.bundle.js
#	dist/scripts/rhinostyle.min.js
#	dist/scripts/rhinostyle.min.js.map
#	package.json
#	yarn.lock
…ild-updates

# Conflicts:
#	build/css/rhinostyle-docs.css
#	build/metalsmith-changed-ctimes.json
#	dist/scripts/rhinostyle.min.js
…ild-updates

# Conflicts:
#	build/css/rhinostyle-docs.css
#	build/metalsmith-changed-ctimes.json
#	build/scripts/rhinostyle-docs.js
#	build/scripts/vendor.bundle.js
#	dist/css/rhinostyle.css
#	dist/scripts/rhinostyle.min.js
#	dist/scripts/rhinostyle.min.js.map
@mcraiganthony mcraiganthony merged commit c22c257 into master Mar 6, 2017
@benbruning benbruning deleted the zach/build-updates branch June 14, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants