Skip to content

Commit

Permalink
aix: skip command line check for test-fatal-error
Browse files Browse the repository at this point in the history
Node.js currently rewrites the process command line on AIX.
Refs: nodejs/node#10607
  • Loading branch information
richardlau committed Jan 20, 2017
1 parent 1930ce1 commit c9eaef8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
4 changes: 4 additions & 0 deletions test/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ exports.findReports = (pid) => {
return files.filter((file) => filePattern.test(file));
};

exports.isAIX = () => {
return process.platform === 'aix';
};

exports.isPPC = () => {
return process.arch.startsWith('ppc');
};
Expand Down
10 changes: 7 additions & 3 deletions test/test-fatal-error.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,12 @@ if (process.argv[2] === 'child') {
const reports = common.findReports(child.pid);
tap.equal(reports.length, 1, 'Found reports ' + reports);
const report = reports[0];
common.validate(tap, report, {pid: child.pid,
commandline: child.spawnargs.join(' ')
});
const options = {pid: child.pid};
// Node.js currently overwrites the command line on AIX
// https://github.com/nodejs/node/issues/10607
if (!common.isAIX()) {
options.commandline = child.spawnargs.join(' ');
}
common.validate(tap, report, options);
});
}

0 comments on commit c9eaef8

Please sign in to comment.