Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/accurate-scoring-onload-fix #1

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

rider-griffin
Copy link
Owner

@rider-griffin rider-griffin commented Mar 11, 2021

  • registerDomElements() is called upon instantiation to accurately calculate score of the the question. This is necessary for parent libraries, such as Interactive Video, because score calculation requires the question to exist in the DOM.
  • Before this change, this would cause users to lose score data upon leaving and coming back to a content such as interactive video, essentially forcing them to revisit every question they've answered in order to receive an accurate score. This change also fixes the issue of the endscreen of Interactive Video reflecting 0's on all scores related to multiple choice questions.

More details on this issue are cited here:
https://h5p.org/node/547910
h5p/h5p-interactive-video#154

@rider-griffin rider-griffin merged commit 960a8e4 into master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant