Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riemann-kvminstance(s) duplicate scripts #34

Closed
ghost opened this issue Apr 26, 2013 · 3 comments · Fixed by #39
Closed

riemann-kvminstance(s) duplicate scripts #34

ghost opened this issue Apr 26, 2013 · 3 comments · Fixed by #39

Comments

@ghost
Copy link

ghost commented Apr 26, 2013

We've got both bin/riemann-kvminstances and bin/riemann-kvminstance. @wjimenez5271, which one would you like to keep?

https://github.com/aphyr/riemann-tools/blob/master/bin/riemann-kvminstance
https://github.com/aphyr/riemann-tools/blob/master/bin/riemann-kvminstances

@wjimenez5271
Copy link
Contributor

They are the same files, I'm fuzzy on why there are two files that got committed, but I do recall changing the name of the file at some point to be singular instead of plural since that appeared to be more in line with how you were naming the scripts...all that to say we should keep riemann-kvminstance :-).

Do you want me to do anything to remove the other one?

@default50
Copy link
Contributor

Just made the change per @wjimenez5271 decision.

@gsandie
Copy link
Contributor

gsandie commented May 11, 2013

Closed via #39

@gsandie gsandie closed this as completed May 11, 2013
fborgnia pushed a commit to riemann/riemann-redis that referenced this issue Mar 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants